Docs Ingestion page refactor#11541
Closed
techdocsmith wants to merge 107 commits intoapache:masterfrom
Closed
Conversation
Contributor
Author
|
@sthetland & @vtlim , @loquisgon PTAL |
sthetland
requested changes
Aug 3, 2021
sthetland
left a comment
sthetland
left a comment
There was a problem hiding this comment.
Good move splitting up the pages. Comments below.
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
* add_DynamicConfigProvider_for_schema_registry * bug fixed * add document * fix document * fix spot bug * fix document * inject ObjectMapper * add DynamicConfigProviderUtils * add UT * bug fixed Co-authored-by: yuanyi <yuanyi@freewheel.tv>
vtlim
reviewed
Aug 3, 2021
Member
vtlim
left a comment
vtlim
left a comment
There was a problem hiding this comment.
I noticed a few other things I couldn't edit, will make the changes on my end and push to your branch
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
minor changes from review
sthetland
requested changes
Aug 11, 2021
sthetland
left a comment
sthetland
left a comment
There was a problem hiding this comment.
Again, nice refactor. A few nits from some spot checking, but also I think a merge conflict snuck through.
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: sthetland <steve.hetland@imply.io>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>
Contributor
Author
|
@sthetland , @suneet-s , I think I finally got all the merge conflicts, spelling, and link checking handled. What a challenge. |
techdocsmith
added a commit
to techdocsmith/druid
that referenced
this pull request
Aug 11, 2021
2 tasks
Contributor
Author
|
This PR got out of sync beyond repair. #11576 carries it. cc: @suneet-s , @sthetland |
sthetland
pushed a commit
that referenced
this pull request
Aug 13, 2021
* Docs refactor of ingestion. Carries #11541 * Update docs/misc/math-expr.md * add Apache license * fix header, add topics to sidebar * Update docs/ingestion/partitioning.md * pick up changes to and md from c7fdf1d, #11479 Co-authored-by: Suneet Saldanha <suneet@apache.org> Co-authored-by: Jihoon Son <jihoonson@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
16 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor ingestion into smaller topics. Clean up some style here and there.
Description
This PR breaks down the ingestion landing page topic into smaller topics. Some benefits include:
There may be some trade off in topic maintenance. For example if there's an enhancement to rollup, we may need to edit
rollup.mdandingestion-spec.md.This PR has: