Suppress stacktrace of InterruptedException in CommonCacheNotifier#11715
Suppress stacktrace of InterruptedException in CommonCacheNotifier#11715abhishekagarwal87 merged 3 commits intoapache:masterfrom
Conversation
|
how does the |
| LOG.debug(callerName + ":Received responses for cache update notifications."); | ||
| } | ||
| catch (InterruptedException e) { | ||
| LOG.noStackTrace() |
There was a problem hiding this comment.
should this be emitted as an alert?
There was a problem hiding this comment.
I guess we could just log an INFO here instead.
There was a problem hiding this comment.
makes sense to me.
|
The stack trace from the InterruptedException might give the wrong notion that something went wrong with the shutdown. By graceful shutdown, I meant avoiding the above confusion. Let me fix this description 🙂 |
Thanks 🙂 |
|
Ignoring code coverage check and merging since it is just a logging change. |
Addresses #10709
Description
When
CommonCachedNotifieris being stopped while the thread is waiting onupdateQueue.take(),an InterruptedException is thrown. The stack trace from this exception gives the wrong idea that something went wrong with the shutdown.
This PR has: