Fix router documentation for druid.router.sql.enable#11716
Merged
abhishekagarwal87 merged 3 commits intoapache:masterfrom Sep 28, 2021
Merged
Fix router documentation for druid.router.sql.enable#11716abhishekagarwal87 merged 3 commits intoapache:masterfrom
druid.router.sql.enable#11716abhishekagarwal87 merged 3 commits intoapache:masterfrom
Conversation
docs/configuration/index.md
Outdated
| |`druid.router.defaultRule`|The default rule for all datasources.|"_default"| | ||
| |`druid.router.pollPeriod`|How often to poll for new rules.|PT1M| | ||
| |`druid.router.sql.enable`|Enable routing of SQL queries. Possible values are `true` and `false`. When set to `true`, the Router uses the provided strategies to determine the broker service for a given SQL query.|`false`| | ||
| |`druid.router.sql.enable`|Enable routing of SQL queries using strategies. Possible values are `true` and `false`. When set to `true`, the Router uses the provided strategies to determine the broker service for a given SQL query. When set to `false`, the Router uses the `defaultBrokerServiceName`.|`false`| |
Contributor
There was a problem hiding this comment.
can you also add what strategies are supported?
Contributor
Author
There was a problem hiding this comment.
The details of strategies are present in docs/design/router.md. I figured we only need a summary here.
techdocsmith
requested changes
Sep 23, 2021
Contributor
techdocsmith
left a comment
techdocsmith
left a comment
There was a problem hiding this comment.
Request some style changes, minor clarifications.
Co-authored-by: Charles Smith <techdocsmith@gmail.com>
Contributor
Author
|
Thanks a lot for the review, @techdocsmith ! I have committed your suggestions. |
abhishekagarwal87
approved these changes
Sep 24, 2021
Contributor
|
Thank you @kfaraz. I have merged the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
AsyncQueryForwardingServlet.routeSqlQueriestorouteSqlByStrategyThis PR has: