Fix task report streaming in https setups.#11739
Merged
clintropolis merged 3 commits intoapache:masterfrom Oct 23, 2021
Merged
Conversation
kfaraz
reviewed
Oct 6, 2021
| return tlsPort; | ||
| } | ||
|
|
||
| public URL makeURL(final String encodedPathAndQueryString) throws MalformedURLException |
Contributor
There was a problem hiding this comment.
nit: Would makeUrl be more camel-casey?
Although, the community as well as the Druid repo seems a little divided on this. 😃
Contributor
Author
There was a problem hiding this comment.
There doesn't seem to be much consistency here, like you said 🤠
I went with URL since there are so many other URLs in the same line (java.net.URL, MalformedURLException) so it seemed reasonable.
clintropolis
approved these changes
Oct 23, 2021
Member
|
failing CI is the k8s test, which should be resolved by #11832 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TaskRunnerUtils.makeTaskLocationURL, which is only used by task report streaming, was not checking the https port. In common https-only setups, http is disabled, meaning task report streaming would not work at all.