Simplify ITHttpInputSourceTest to mitigate flakiness#11751
Merged
jon-wei merged 6 commits intoapache:masterfrom Oct 12, 2021
Merged
Simplify ITHttpInputSourceTest to mitigate flakiness#11751jon-wei merged 6 commits intoapache:masterfrom
jon-wei merged 6 commits intoapache:masterfrom
Conversation
added 2 commits
October 8, 2021 10:21
…ot required thus changing to dynamic
loquisgon
changed the title
jon-wei
approved these changes
Oct 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reenables
ITHttpInputSourceTestand simplifies it to have it use fewer resources. This test started being more flaky, i.e. intermittent failures a few days ago, so it was disabled for debugging. Now it seems fine and passing. But rather than leave it as is it is better to change its ingestion todynamicrather thanhashso it uses fewer resources. Besides analysis of failures did not indicate anything wrong with the tests and rather the cause was pointing to potential Travis (lack) of resources. This PR also removes the use of sketches during ingestion to further simplify the test without affecting its purpose of testing HTTP input source.