Skip to content

Minor processor quota computation fix + docs#11783

Merged
jon-wei merged 17 commits intoapache:masterfrom
arunramani:master
Oct 9, 2021
Merged

Minor processor quota computation fix + docs#11783
jon-wei merged 17 commits intoapache:masterfrom
arunramani:master

Conversation

@arunramani
Copy link
Contributor

Description

Set processor quota to -1 if quota is negative or period is 0. Added docs on how to enable the monitors

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

Copy link
Contributor

@abhishekagarwal87 abhishekagarwal87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor style suggestions. Otherwise LGTM. I'm figuring that anyone looking to deal with monitoring at this level will understand standard abbreviations.

@clintropolis clintropolis reopened this Oct 8, 2021
@jon-wei jon-wei merged commit b6b42d3 into apache:master Oct 9, 2021
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants