Missing "Loader=yaml.FullLoader" parameter in generate-binary-license and generate-binary-notice py scripts#11815
Merged
abhishekagarwal87 merged 1 commit intoapache:masterfrom Oct 19, 2021
Conversation
…ry-notice py scripts
Contributor
|
Merged since CI failures are unrelated. Thank you @davidferlay |
Member
|
this PR seems to have broken the k8s integration test, which now fails with https://app.travis-ci.com/github/apache/druid/jobs/544715776#L1329 |
Member
|
@davidferlay We had to revert this change to unblock CI, but it still seems worth doing, would you like to try again and see if you can determine why the k8s integration test was not passing and how to fix? |
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11814.
Description
yaml.load_allis missingLoaderparameter in these 2 files :This PR has: