Add info for compation config dialog#11847
Merged
vogievetsky merged 7 commits intoapache:masterfrom Nov 2, 2021
Merged
Conversation
vogievetsky
reviewed
Oct 28, 2021
| info: <p>Maximum number of rows to include in a partition.</p>, | ||
| info: ( | ||
| <> | ||
| <p>Maximum number of rows to include in a partition.</p>{' '} |
Contributor
There was a problem hiding this comment.
I don't think you need the {' '} in this line, I bet it was just a typo that prettier fixed up for you. Otherwise these changes look good!
Contributor
Author
There was a problem hiding this comment.
Thank you for spotting my typo, removed it
…for-compation-config-dialog
This reverts commit 28b2873.
Contributor
|
Trying to get travis to re-run |
Contributor
|
hmm I wonder why travis is so finicky |
Contributor
|
@suneet-s seems like we were hitting the quota. Now it looks better. |
vogievetsky
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once auto compaction with single_dim partitioning is configured, you can not switch from using targetRows to maxRows easily in the web console
Add details in
compaction-dialog infoto address leave blank can show the properties of the selected partitioning typehashed- [optional but can only submit the config form with one of the properties]maxRowsPerSegmenttargetRowsPerSegmentnumShardssingle_dim- [required and can only submit the config form with one of the properties]maxRowsPerSegmenttargetRowsPerSegmentDescription
Key changed/added classes in this PR
compaction-config.tsxThis PR has: