Skip to content

Update default values for tuning parameters in kinesis data loader UI#11867

Merged
abhishekagarwal87 merged 1 commit intoapache:masterfrom
abhishekagarwal87:kinesis-default-values
Nov 2, 2021
Merged

Update default values for tuning parameters in kinesis data loader UI#11867
abhishekagarwal87 merged 1 commit intoapache:masterfrom
abhishekagarwal87:kinesis-default-values

Conversation

@abhishekagarwal87
Copy link
Contributor

Follow up PR on #11767 to update the data loader UI in the console. Default values used on the druid backend are different from what we see on the kinesis data loader UI.

@kfaraz
Copy link
Contributor

kfaraz commented Nov 2, 2021

@abhishekagarwal87 , could you please specify where the default values are defined on the backend?
If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.

@abhishekagarwal87
Copy link
Contributor Author

@abhishekagarwal87 , could you please specify where the default values are defined on the backend? If possible, maybe add a comment in the respective class to update these files whenever those default values are updated.

That will be a lot of classes to change since console shows the default value for many different tuning configuration classes :)

@abhishekagarwal87 abhishekagarwal87 merged commit 652e149 into apache:master Nov 2, 2021
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants