Update default values for tuning parameters in kinesis data loader UI#11867
Merged
abhishekagarwal87 merged 1 commit intoapache:masterfrom Nov 2, 2021
Merged
Conversation
Contributor
|
@abhishekagarwal87 , could you please specify where the default values are defined on the backend? |
Contributor
Author
That will be a lot of classes to change since console shows the default value for many different tuning configuration classes :) |
kfaraz
approved these changes
Nov 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up PR on #11767 to update the data loader UI in the console. Default values used on the druid backend are different from what we see on the kinesis data loader UI.