Skip to content

Comments

Document expression post-aggregators#11896

Merged
FrankChen021 merged 2 commits intoapache:masterfrom
jacobtolar:patch-4
Apr 19, 2022
Merged

Document expression post-aggregators#11896
FrankChen021 merged 2 commits intoapache:masterfrom
jacobtolar:patch-4

Conversation

@jacobtolar
Copy link
Contributor

@jacobtolar jacobtolar commented Nov 9, 2021

Description

There was no documentation about expression post-aggregators; adding that here.

Also adding a note that the arithmetic post-aggregator always uses floating point arithmetic ( per the latest commit.)


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster. (I didn't test exhaustively, but I verified that some queries with the syntax documented here work as expected).

Copy link
Member

@FrankChen021 FrankChen021 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. Please fix the typo above.

Co-authored-by: Frank Chen <frankchen@apache.org>
@stale
Copy link

stale bot commented Apr 18, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2022
@stale
Copy link

stale bot commented Apr 19, 2022

This pull request/issue is no longer marked as stale.

@stale stale bot removed the stale label Apr 19, 2022
@FrankChen021 FrankChen021 merged commit 0edc221 into apache:master Apr 19, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants