Skip to content

Docs - added another common config property to tuningConfig#11935

Merged
FrankChen021 merged 4 commits intoapache:masterfrom
petermarshallio:20211117-docs-indexSpecForIntermediatePersists
Apr 18, 2022
Merged

Docs - added another common config property to tuningConfig#11935
FrankChen021 merged 4 commits intoapache:masterfrom
petermarshallio:20211117-docs-indexSpecForIntermediatePersists

Conversation

@petermarshallio
Copy link
Contributor

@petermarshallio petermarshallio commented Nov 17, 2021

I noticed that indexSpecForIntermediatePersists is a common configuration property across ingestion task types, so have added it alongside indexSpec on the main tuningConfig section.
Also updates the definition for indexSpec to closer mirror the definitions given in the tables for individual ingestion task types.

This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

Added indexSpecForIntermediatePersists as a common configuration property.
@petermarshallio
Copy link
Contributor Author

Would you mind doing a double-check that this is correct @sergioferragut ?
@techdocsmith another small one.

Amended to remove "below" and add link to the table.
Removed passive.
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link

stale bot commented Apr 17, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Apr 17, 2022
@FrankChen021 FrankChen021 merged commit 1201c9b into apache:master Apr 18, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants