Merged
Conversation
gianm
approved these changes
Nov 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a logging bug in the
BatchAppendratorclass when hydrants are persisted. The bug is that the count of hydrants before this class was added was being kept in theIncrementalIndexand obtained using itsgetCount()method. Now the hydrant count is being kept in the newsinksMetadatathat keeps tracks ofSinkmetadata (such as the hydrant count). The reason to change the place for keeping that count is that Sinks & Hydrants are no longer kept in memory as soon as they are persisted.This PR has: