Skip to content

Log correct hydrant count#11976

Merged
a2l007 merged 1 commit intoapache:masterfrom
loquisgon:fix_log_hydrant_count
Nov 23, 2021
Merged

Log correct hydrant count#11976
a2l007 merged 1 commit intoapache:masterfrom
loquisgon:fix_log_hydrant_count

Conversation

@loquisgon
Copy link

@loquisgon loquisgon commented Nov 22, 2021

Description

This PR fixes a logging bug in the BatchAppendrator class when hydrants are persisted. The bug is that the count of hydrants before this class was added was being kept in the IncrementalIndex and obtained using its getCount() method. Now the hydrant count is being kept in the new sinksMetadata that keeps tracks of Sink metadata (such as the hydrant count). The reason to change the place for keeping that count is that Sinks & Hydrants are no longer kept in memory as soon as they are persisted.


This PR has:

  • [ X] been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • [X ] been tested in a test Druid cluster.

@a2l007 a2l007 assigned a2l007 and unassigned a2l007 Nov 23, 2021
@a2l007 a2l007 merged commit 311d9a2 into apache:master Nov 23, 2021
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants