Skip to content

Comments

Update tutorial-compaction.md to change an unclear statement#11988

Merged
FrankChen021 merged 2 commits intoapache:masterfrom
Vespira:patch-1
Apr 18, 2022
Merged

Update tutorial-compaction.md to change an unclear statement#11988
FrankChen021 merged 2 commits intoapache:masterfrom
Vespira:patch-1

Conversation

@Vespira
Copy link
Contributor

@Vespira Vespira commented Nov 24, 2021

Unclear statement on the explanation of tuningConfig section.

Description

Tiny PR just to modify an unclear statement in the tutorial documentation section about Segment compaction task.

Rephrased a little bit sentence


This PR has:

  • been self-reviewed.

Unclear statement on the explanation of tuningConfig section.
@kfaraz
Copy link
Contributor

kfaraz commented Nov 25, 2021

Thanks for the changes @Vespira .
But I think the old statement is probably easier to understand, especially if you read it with the statement right after.

In this tutorial example, only one compacted segment will be created per hour, as each hour has less rows than the 5000000 maxRowsPerSegment (note that the total number of rows is 39244).

Co-authored-by: Kashif Faraz <kashif.faraz@gmail.com>
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stale
Copy link

stale bot commented Apr 18, 2022

This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2022
@FrankChen021
Copy link
Member

Sorry for the late merge. Thank you for your first contribution on Druid @Vespira

@stale
Copy link

stale bot commented Apr 18, 2022

This issue is no longer marked as stale.

@stale stale bot removed the stale label Apr 18, 2022
@FrankChen021 FrankChen021 merged commit 9f2b37f into apache:master Apr 18, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants