Fix druid client timeout zero#12023
Merged
clintropolis merged 6 commits intoapache:masterfrom Dec 7, 2021
Merged
Conversation
jihoonson
approved these changes
Dec 3, 2021
abhishekagarwal87
approved these changes
Dec 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The documentation specifies that using a
timeoutof0, however this was actually a lie and specifying a timeout of 0 would cause a query to timeout and fail immediately.This PR fixes this issue, but also doesn't completely allow infinite timeout to be totally within the users control (with no way for the server-side to mitigate) so instead allows 0 to use the maximum server-side timeout
druid.server.http.maxQueryTimeout, which defaults toLong.MAX_VALUEso is effectively unlimited unless explicitly configured by operators.This PR has: