Skip to content

Fix druid client timeout zero#12023

Merged
clintropolis merged 6 commits intoapache:masterfrom
clintropolis:fix-druid-client-timeout-zero
Dec 7, 2021
Merged

Fix druid client timeout zero#12023
clintropolis merged 6 commits intoapache:masterfrom
clintropolis:fix-druid-client-timeout-zero

Conversation

@clintropolis
Copy link
Member

Description

The documentation specifies that using a timeout of 0, however this was actually a lie and specifying a timeout of 0 would cause a query to timeout and fail immediately.

This PR fixes this issue, but also doesn't completely allow infinite timeout to be totally within the users control (with no way for the server-side to mitigate) so instead allows 0 to use the maximum server-side timeout druid.server.http.maxQueryTimeout, which defaults to Long.MAX_VALUE so is effectively unlimited unless explicitly configured by operators.


This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • been tested in a test Druid cluster.

@clintropolis clintropolis merged commit a8815f6 into apache:master Dec 7, 2021
@clintropolis clintropolis deleted the fix-druid-client-timeout-zero branch December 7, 2021 20:41
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants