MySqlFirehoseDatabaseConnector uses configured driver class name#12049
Merged
suneet-s merged 1 commit intoapache:masterfrom Dec 10, 2021
Merged
MySqlFirehoseDatabaseConnector uses configured driver class name#12049suneet-s merged 1 commit intoapache:masterfrom
suneet-s merged 1 commit intoapache:masterfrom
Conversation
jihoonson
approved these changes
Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If a user configures Druid to use the mariadb driver instead of mysql, they would also need to update the mysql input source to tell it to use the mariadb driver to get ingestion to succeed.
Since we're already asking users to choose their driver in the mySQLConnectorDriverConfig, we use this driver instead of trying to guess the driver based on the connectURI.
This was found by the
ITSqlInputSourceTestyay integration tests! :)This PR has: