Skip to content

MySqlFirehoseDatabaseConnector uses configured driver class name#12049

Merged
suneet-s merged 1 commit intoapache:masterfrom
suneet-s:up-maria
Dec 10, 2021
Merged

MySqlFirehoseDatabaseConnector uses configured driver class name#12049
suneet-s merged 1 commit intoapache:masterfrom
suneet-s:up-maria

Conversation

@suneet-s
Copy link
Contributor

@suneet-s suneet-s commented Dec 9, 2021

Description

If a user configures Druid to use the mariadb driver instead of mysql, they would also need to update the mysql input source to tell it to use the mariadb driver to get ingestion to succeed.
Since we're already asking users to choose their driver in the mySQLConnectorDriverConfig, we use this driver instead of trying to guess the driver based on the connectURI.

This was found by the ITSqlInputSourceTest yay integration tests! :)
This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@suneet-s suneet-s added the Bug label Dec 9, 2021
@suneet-s suneet-s merged commit 25ac04e into apache:master Dec 10, 2021
@suneet-s suneet-s deleted the up-maria branch December 10, 2021 04:58
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants