Lock count guardrail for parallel single phase/sequential task#12052
Merged
jon-wei merged 2 commits intoapache:masterfrom Dec 15, 2021
Merged
Lock count guardrail for parallel single phase/sequential task#12052jon-wei merged 2 commits intoapache:masterfrom
jon-wei merged 2 commits intoapache:masterfrom
Conversation
zachjsh
reviewed
Dec 13, 2021
...xing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractBatchIndexTask.java
Outdated
Show resolved
Hide resolved
zachjsh
reviewed
Dec 13, 2021
...n/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java
Show resolved
Hide resolved
zachjsh
reviewed
Dec 13, 2021
...org/apache/druid/indexing/common/task/batch/parallel/SinglePhaseParallelIndexTaskRunner.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a
maxAllowedLockCounttuning config parameter for the parallel single phase and sequential modes that serves as a guardrail on the number of locks that the task set is allowed to acquired. An excessive number of locks can result in a very slow task and excessive load on the overlord.This PR has: