Skip to content

perf: cache row if it is a transformed row #12113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suneet-s merged 2 commits into from
Feb 15, 2022
Merged

perf: cache row if it is a transformed row #12113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5bf002
perf: cache row if it is a transformed row
jasonk000 Jan 3, 2022
f444ad2
perf: cache row if it is a transformed row (also cache DateTime object)
jasonk000 Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 17 additions & 10 deletions processing/src/main/java/org/apache/druid/segment/transform/Transformer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,15 @@ public static class TransformedInputRow implements InputRow
private final InputRow row;
private final Map<String, RowFunction> transforms;

// cached column, because it will be read frequently
private final DateTime timestamp;

public TransformedInputRow(final InputRow row, final Map<String, RowFunction> transforms)
{
this.row = row;
this.transforms = transforms;

this.timestamp = readTimestampFromRow(row, transforms);
}

@Override
Expand All @@ -158,27 +163,29 @@ public List<String> getDimensions()
return row.getDimensions();
}

@Override
public long getTimestampFromEpoch()
static DateTime readTimestampFromRow(final InputRow row, final Map<String, RowFunction> transforms)
{
final RowFunction transform = transforms.get(ColumnHolder.TIME_COLUMN_NAME);
final long ts;
if (transform != null) {
//noinspection ConstantConditions time column is never null
return Rows.objectToNumber(ColumnHolder.TIME_COLUMN_NAME, transform.eval(row), true).longValue();
ts = Rows.objectToNumber(ColumnHolder.TIME_COLUMN_NAME, transform.eval(row), true).longValue();
} else {
return row.getTimestampFromEpoch();
ts = row.getTimestampFromEpoch();
}
return DateTimes.utc(ts);
}

@Override
public long getTimestampFromEpoch()
{
return timestamp.getMillis();
}

@Override
public DateTime getTimestamp()
{
final RowFunction transform = transforms.get(ColumnHolder.TIME_COLUMN_NAME);
if (transform != null) {
return DateTimes.utc(getTimestampFromEpoch());
} else {
return row.getTimestamp();
}
return timestamp;
}

@Override
Expand Down