Skip to content

Web console: make range partitioning a first class citizen of the console#12146

Merged
clintropolis merged 2 commits intoapache:masterfrom
vogievetsky:range
Jan 12, 2022
Merged

Web console: make range partitioning a first class citizen of the console#12146
clintropolis merged 2 commits intoapache:masterfrom
vogievetsky:range

Conversation

@vogievetsky
Copy link
Contributor

This PR gives range partitioning first class treatment.

image

Now you can select range from the dropdown (instead of single_dim) and the warning about the dimension order and the partition dimensions not matching up is there also.

Also added suggestions to the string-array input:

image

This PR has:

  • been self-reviewed.
  • been tested in a test Druid cluster.

@clintropolis clintropolis merged commit 9cd52ed into apache:master Jan 12, 2022
@vogievetsky vogievetsky deleted the range branch January 12, 2022 16:07
@kfaraz
Copy link
Contributor

kfaraz commented Jan 12, 2022

Thanks a lot for the changes, @vogievetsky !

Sorry for the late comment as I missed this PR earlier.

I was wondering if we should include a small message/tooltip saying something like

`range` partitioning is the evolved form of `single_dim`, which allows you to perform range partitioning on multiple dimensions instead of just one. To continue to use single dim partitioning, just select `range` and specify only one dimension in your partition dimensions list

or something a little more concise 😅

I think it would avoid confusion for people who are used to seeing single_dim in the dropdowns.

@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
sachinsagare pushed a commit to pinterest/druid that referenced this pull request Oct 28, 2022
…sole (apache#12146)

* first class support for range partitioning

* update e2e tests

(cherry picked from commit 9cd52ed)
sachinsagare pushed a commit to sachinsagare/druid that referenced this pull request Nov 3, 2022
…sole (apache#12146)

* first class support for range partitioning

* update e2e tests

(cherry picked from commit 9cd52ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants