Web console: make range partitioning a first class citizen of the console#12146
Merged
clintropolis merged 2 commits intoapache:masterfrom Jan 12, 2022
Merged
Web console: make range partitioning a first class citizen of the console#12146clintropolis merged 2 commits intoapache:masterfrom
clintropolis merged 2 commits intoapache:masterfrom
Conversation
clintropolis
approved these changes
Jan 12, 2022
Contributor
|
Thanks a lot for the changes, @vogievetsky ! Sorry for the late comment as I missed this PR earlier. I was wondering if we should include a small message/tooltip saying something like or something a little more concise 😅 I think it would avoid confusion for people who are used to seeing single_dim in the dropdowns. |
sachinsagare
pushed a commit
to pinterest/druid
that referenced
this pull request
Oct 28, 2022
…sole (apache#12146) * first class support for range partitioning * update e2e tests (cherry picked from commit 9cd52ed)
sachinsagare
pushed a commit
to sachinsagare/druid
that referenced
this pull request
Nov 3, 2022
…sole (apache#12146) * first class support for range partitioning * update e2e tests (cherry picked from commit 9cd52ed)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR gives range partitioning first class treatment.
Now you can select
rangefrom the dropdown (instead ofsingle_dim) and the warning about the dimension order and the partition dimensions not matching up is there also.Also added suggestions to the
string-arrayinput:This PR has: