Fix for overflowing localInterval in SegmentCostCache.Bucket#12257
Merged
kfaraz merged 7 commits intoapache:masterfrom Feb 17, 2022
Merged
Conversation
Contributor
|
Merging as CI failure is unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combination of cachingCost balancer + all segmentGranularity + no interval not loading segments after ingestion
ETERNITYInterval (start -Long.MIN_VALUE/2, end -Long.MAX_VALUE/2)SegmentCostCachebuckets is posing the problem as the buckets are designed in such a way to havebucket_interval_start < segment_interval_start.MILLIS_FACTOR(millis_in_day/ log2), as a result, segment end-time conversion difference is overflowing(Long value).MILLIS_FACTORfirst (since MILLIS_FACTOR is of order 10^8) and then takes the difference.Key changed/added classes in this PR
SegmentsCostCache.BucketLoadRuleTestThis PR has: