Improve dictionary#indexOf routine with sparse index#12294
Closed
hqx871 wants to merge 1 commit intoapache:masterfrom
Closed
Improve dictionary#indexOf routine with sparse index#12294hqx871 wants to merge 1 commit intoapache:masterfrom
hqx871 wants to merge 1 commit intoapache:masterfrom
Conversation
31d3eb6 to
011368e
Compare
011368e to
48c0389
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use sparse index to improve GenericIndexed#indexOf performance, especially for large dictionary.
Description
The sorted GenericalIndexed#indexOf use binary search to get index of one object value. This routine will call ObjectStrategy#fromByteBuffer to decode value from the byteBuffer, which is expensive. I suggest build a sparse index for large dictionary when load it. this can get 40+% performance improvement. I made a benchmark here.
Key changed/added classes in this PR
SparseArrayIndexedGenericIndexedDictionaryWrapStrategyThis PR has: