fix supervisor auto scaler config serde bug#12317
Merged
clintropolis merged 1 commit intoapache:masterfrom Mar 10, 2022
Merged
Conversation
Contributor
|
Ack. Will review ASAP Thanks for this patch. |
FrankChen021
approved these changes
Mar 8, 2022
zhangyue19921010
approved these changes
Mar 9, 2022
Contributor
zhangyue19921010
left a comment
zhangyue19921010
left a comment
There was a problem hiding this comment.
LTGM We could land it once tested passed. Thanks for this patch!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Supervisor auto scaler config becomes null on coordinator restart. This is because
SeekableStreamSupervisorIOConfighas propertyautoScalerConfigbut the getter is calledgetAutoscalerConfigso while serializing the property name becomesautoscalerConfigwith small casesand therefore while deserialzingautoScalerConfigbecomesnull. This PR fixes the spelling of getter. Also added proper formatting forSeekableStreamSupervisorSpecTestclass.Key changed/added classes in this PR
SeekableStreamSupervisorIOConfigKafkaSupervisorIOConfigTestThis PR has: