Skip to content

Git hooks should fail on errors; pass args to git hooks#12322

Merged
jihoonson merged 2 commits intoapache:masterfrom
jihoonson:fail-hook-on-error
Mar 10, 2022
Merged

Git hooks should fail on errors; pass args to git hooks#12322
jihoonson merged 2 commits intoapache:masterfrom
jihoonson:fail-hook-on-error

Conversation

@jihoonson
Copy link
Contributor

@jihoonson jihoonson commented Mar 9, 2022

Description

Fixes two bugs in the script added in #12300.

  • It should fail when one of the scripts it calls fails.
  • Arguments should pass to the script especially when it is called in the pre-push hook.

This PR has:

  • been self-reviewed.

@jihoonson jihoonson added the Area - Dev For items related to the project itself, like dev docs and checklists, but not CI label Mar 9, 2022
@jihoonson
Copy link
Contributor Author

jihoonson commented Mar 10, 2022

Thanks @maytasm for the review.

@jihoonson jihoonson merged commit d89d4ff into apache:master Mar 10, 2022
TSFenwick pushed a commit to TSFenwick/druid that referenced this pull request Apr 11, 2022
@jihoonson @TSFenwick
Git hooks should fail on errors; pass args to git hooks (apache#12322)
9855dde 
* Git hooks should fail on errors

* don't set shell to pass args
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maytasm maytasm maytasm approved these changes

Assignees

No one assigned

Labels

Area - Dev For items related to the project itself, like dev docs and checklists, but not CI

Projects

None yet

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jihoonson @maytasm @abhishekagarwal87