Skip to content

Comments

docs(fix): clarify how worker.version and minWorkerVersion comparison works#12459

Merged
techdocsmith merged 5 commits intoapache:masterfrom
317brian:worker-version-properties
May 16, 2022
Merged

docs(fix): clarify how worker.version and minWorkerVersion comparison works#12459
techdocsmith merged 5 commits intoapache:masterfrom
317brian:worker-version-properties

Conversation

@317brian
Copy link
Contributor

Add explanation that the value is treated as a string, so it works unintuitively if you don't provide the version in ISO format.

This PR has:

  • been self-reviewed.

@317brian 317brian changed the title docs(fix): clarify how worker.version and minWorkerVersion comparison workers docs(fix): clarify how worker.version and minWorkerVersion comparison works Apr 19, 2022
Copy link
Contributor

@zachjsh zachjsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes for style

Co-authored-by: Charles Smith <techdocsmith@gmail.com>
Copy link
Contributor

@techdocsmith techdocsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@techdocsmith techdocsmith merged commit 351e57b into apache:master May 16, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 24.0.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants