Merged
Conversation
# Conflicts: # owasp-dependency-check-suppressions.xml
suneet-s
reviewed
Apr 20, 2022
| </suppress> | ||
|
|
||
| <suppress> | ||
| <!-- Suppress cves that aren't applicable to hadoop client --> |
Contributor
There was a problem hiding this comment.
It looks like we already have a section for suppressions like this in
druid/owasp-dependency-check-suppressions.xml
Lines 322 to 329 in 691e26d
Can you combine this with that section.
This comment explaining why the CVE is being suppressed is great!
suneet-s
approved these changes
Apr 21, 2022
Contributor
suneet-s
left a comment
suneet-s
left a comment
There was a problem hiding this comment.
Thanks @tejaswini-imply !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Suppressing this CVE since we are only using hadoop client.
This PR has: