Web console: add a button to get out of restricted mode, make capability detection more robust#12503
Merged
vogievetsky merged 2 commits intoapache:masterfrom May 5, 2022
Conversation
clintropolis
approved these changes
May 5, 2022
Member
clintropolis
left a comment
clintropolis
left a comment
There was a problem hiding this comment.
i guess the button is to avoid a page refresh if it fails to detect capabilities correctly?
| try { | ||
| await Api.instance.post( | ||
| '/druid/v2/sql', | ||
| '/druid/v2/sql?capabilities', |
Member
There was a problem hiding this comment.
is the ?capabilities query parameter just for fun?
Contributor
Author
There was a problem hiding this comment.
it is mostly for being able to identify these bad boys in the Network tab:
Contributor
Author
Or if the capabilities detection code fails in general for some reason and you want to override it. |
vogievetsky
added a commit
to vogievetsky/druid
that referenced
this pull request
May 13, 2022
…ity detection more robust (apache#12503) * allow unrestrict * update tests
abhishekagarwal87
pushed a commit
that referenced
this pull request
May 16, 2022
* Web console: Misc table fixes (#12489) * Misc table fixes * extract default className * table spacing updates * fix e2e action selector * try more times * make the web console exist again * Web console: add a button to get out of restricted mode, make capability detection more robust (#12503) * allow unrestrict * update tests * Add daily stats to console (#12329) * cleanup Co-authored-by: Atul Mohan <atulmohan.mec@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Making the capability detection better and letting the user override it if needed.