Skip to content

Comments

Use datasketches version 3.2.0#12509

Merged
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:upgrade_datasketches
May 13, 2022
Merged

Use datasketches version 3.2.0#12509
kfaraz merged 1 commit intoapache:masterfrom
kfaraz:upgrade_datasketches

Conversation

@kfaraz
Copy link
Contributor

@kfaraz kfaraz commented May 11, 2022 •
edited
Loading

Description

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@kfaraz kfaraz requested a review from AlexanderSaydakov May 11, 2022 07:00
@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone May 11, 2022
@kfaraz
Copy link
Contributor Author

kfaraz commented May 13, 2022

Thanks for the review, @AlexanderSaydakov.
Merging as the failure is unrelated.

@kfaraz kfaraz merged commit 7ab2170 into apache:master May 13, 2022
kfaraz added a commit to kfaraz/druid that referenced this pull request May 16, 2022
@kfaraz
Use datasketches version 3.2.0 (apache#12509)
2fafbef 
Changes:
- Use apache datasketches version 3.2.0.
- Remove unsafe reflection-based usage of datasketch internals added in apache#12022
@kfaraz kfaraz mentioned this pull request May 16, 2022
Merged
abhishekagarwal87 pushed a commit that referenced this pull request May 17, 2022
@kfaraz
Use datasketches version 3.2.0 (#12509) (#12522)
2806dd7 
Changes:
- Use apache datasketches version 3.2.0.
- Remove unsafe reflection-based usage of datasketch internals added in #12022
@abhishekagarwal87 abhishekagarwal87 mentioned this pull request May 17, 2022
Closed
@kfaraz kfaraz deleted the upgrade_datasketches branch September 30, 2022 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexanderSaydakov AlexanderSaydakov AlexanderSaydakov approved these changes

Assignees

No one assigned

Labels

Area - Dependencies Area - Ingestion

Projects

None yet

Milestone

0.23.0

Development

Successfully merging this pull request may close these issues.

3 participants

@kfaraz @AlexanderSaydakov @abhishekagarwal87