Skip to content

Update year in the notice file and the release process instructions#12622

Merged
abhishekagarwal87 merged 5 commits intoapache:masterfrom
abhishekagarwal87:update_notice
Aug 23, 2022
Merged

Update year in the notice file and the release process instructions#12622
abhishekagarwal87 merged 5 commits intoapache:masterfrom
abhishekagarwal87:update_notice

Conversation

@abhishekagarwal87
Copy link
Contributor

No description provided.

@abhishekagarwal87 abhishekagarwal87 added this to the 0.23.0 milestone Jun 9, 2022
@clintropolis clintropolis added the Apache Items related to being a part of the ASF label Jun 9, 2022
@abhishekagarwal87 abhishekagarwal87 changed the title Update year in the notice file Update year in the notice file and the release process instructions Jun 9, 2022

You also need to update the version manually in some places for both master branch and the release branch.
- `DRUID_DOCS_VERSION` has to be changed to `0.17.0` in `web-console/src/links.ts`.
- Docker image tag has to be changed to `0.17.0` for all druid services in `distribution/docker/docker-compose.yml`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this part about updating docker-compose.yml is already mentioned https://github.com/apache/druid/blob/master/distribution/asf-release-process-guide.md?plain=1#L62


Once this is completed, open a PR to the master branch. Also, be sure to confirm that these versions are all correct in the release branch, otherwise fix them and open a backport PR to the release branch.

#### Version updates on master and release branch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these can all be done in the master branch and be part of the previous section, maybe instead add a bit that if any of these steps is missed, then update it in master and backport to the release branch?


```bash
$ mvn -DreleaseVersion=0.17.0 -DdevelopmentVersion=0.18.0-SNAPSHOT -Dtag=druid-0.17.0-rc3 -DpushChanges=false clean release:clean release:prepare
$ mvn -Pwebsite-docs -DreleaseVersion=0.17.0 -DdevelopmentVersion=0.18.0-SNAPSHOT -Dtag=druid-0.17.0-rc3 -DpushChanges=false clean release:clean release:prepare
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this do the right thing? The website-docs profile only has the website module, so will it only bump website version or is it additive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. I verified it by running mvn -Pwebsite-docs help:evaluate -Dexpression=project.modules

@abhishekagarwal87 abhishekagarwal87 merged commit f0fc450 into apache:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Apache Items related to being a part of the ASF

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants