fix bug when rewriting sql virtual column registry#12718
Merged
clintropolis merged 2 commits intoapache:masterfrom Jul 1, 2022
Merged
Conversation
imply-cheddar
approved these changes
Jun 30, 2022
cheddar
approved these changes
Jun 30, 2022
Contributor
cheddar
left a comment
There was a problem hiding this comment.
Making the check mark green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a bug in #12241 from a simple mistake I made that results in modifying the Map that is being iterated over ending up in a
ConcurrentModificationException. The added test fails to plan due to this error prior to the changes in this PR, with one of these in the stack trace:I tried to fix this by using
replaceAll, but still saw the exception, so ended up just copying everything to a new collection and going through them that way.This PR has: