Fix flaky IT: ITPerfectRollupParallelBatchIndexTest#12737
Merged
abhishekagarwal87 merged 3 commits intoapache:masterfrom Jul 9, 2022
Merged
Fix flaky IT: ITPerfectRollupParallelBatchIndexTest#12737abhishekagarwal87 merged 3 commits intoapache:masterfrom
abhishekagarwal87 merged 3 commits intoapache:masterfrom
Conversation
Contributor
Author
|
First build passed without incident. |
Contributor
Author
|
First build failed on "indexing module test (jdk11)" but the failure does not seem related. |
Contributor
Author
|
Some tests failed in second build, due to an unrelated download issue. |
| druid_startup_logging_logProperties=true | ||
| druid_server_https_crlPath=/tls/revocations.crl | ||
| druid_worker_capacity=10 | ||
| druid_worker_intermediaryPartitionTimeout=PT60M |
Contributor
There was a problem hiding this comment.
did you notice a failure in indexer as well? I don't think it's a problem there since there is only one LocalIntermediaryDataManager instance.
Contributor
Author
There was a problem hiding this comment.
I was not sure about indexer. Let me try without it.
Contributor
Author
|
Build failed on "indexing modules test (sql compatibility) (jdk11)" |
Contributor
|
oops. Forgot to approve before merging. It was a +1 from me. The failures are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #12692
Description
Due to the race conditions described in this comment,
the ITPerfectRollupParallelBatchIndexTest and possibly other ITs can exhibit flaky behaviour.
This typically happens when the middle manager/indexer cleans up the partitions of a
supervisor task while a different peon is trying to list those partitions (to account for remaining
space in a storage location).
This PR tries to eliminate this behaviour by increasing the partition timeout, so that partitions are
effectively not cleaned up during the course of the test, but only after.
This is not a permanent fix and a better fix would be improving the way the cleanup is handled
between the peons and the middle manager.
Changes
druid_worker_intermediaryPartitionTimeout = PT30Min integration-test env configsThis PR has: