add missing selectors for explicit null columns#12834
Merged
clintropolis merged 1 commit intoapache:masterfrom Jul 30, 2022
Merged
add missing selectors for explicit null columns#12834clintropolis merged 1 commit intoapache:masterfrom
clintropolis merged 1 commit intoapache:masterfrom
Conversation
rohangarg
approved these changes
Jul 29, 2022
processing/src/test/java/org/apache/druid/segment/serde/NullColumnPartSerdeTest.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some missing column selectors to
NullColumnPartSerdeused by explicit null columns (added in #12279). TheVectorObjectSelectoris used by many vector aggregators when they don't care to deal with dictionary id lookup, so this fixes issues when using these aggregators with explicit null columns. I'm not certain if theVectorValueSelectoris actually used in practice, but went ahead and added it just in case.This PR has: