add DictionaryEncodedStringValueIndex implementation to NestedFieldLiteralColumnIndexSupplier#12837
Merged
clintropolis merged 1 commit intoapache:masterfrom Aug 2, 2022
Conversation
…teralColumnIndexSupplier
maytasm
approved these changes
Aug 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an implementation to
DictionaryEncodedStringValueIndextoNestedFieldLiteralColumnIndexSupplier, which is used in a handful of places for doing stuff with dictionary encoded columns, such as native search and segment metadata queries, fixing some bugs.I also removed
getIndexandhasNullsfromDictionaryEncodedStringValueIndex, which were only used by tests.There is another issue not addressed in this PR, which is that these things rely on
ColumnCapabilities.hasBitmapIndexesto check if they can use indexes, which is really no longer adequate to know if something will have the type of indexes that they are going to ask for after #12388. I think in the future we might want to either update column capabilities to include all of the classes theColumnIndexSuppliercan supply, or make these callers check theColumnIndexSupplierthemselves.This PR has: