inject @Json ObjectMapper for to_json_string and parse_json expressions#12900
Merged
gianm merged 4 commits intoapache:masterfrom Aug 15, 2022
Merged
inject @Json ObjectMapper for to_json_string and parse_json expressions#12900gianm merged 4 commits intoapache:masterfrom
gianm merged 4 commits intoapache:masterfrom
Conversation
gianm
approved these changes
Aug 14, 2022
Contributor
|
Looks good to me, once the test is fixed. (The CI failure seems legitimate) |
FrankChen021
approved these changes
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR switches
TO_JSON_STRINGandPARSE_JSONfunctions to use the@JsonannotatedObjectMapperto better tie into the standard JSON serde we use for result formats, as mentioned as an alternative to solving the problem in #12893 (we should do both).This allows a much wider variety of complex types to be translated into strings using
TO_JSON_STRING, many of these likely just being turned into base64 string values, but now they at least work instead of failing with an error such asThis PR has: