DruidQuery: Return a copy from withScanSignatureIfNeeded, as promised.#12906
Merged
gianm merged 1 commit intoapache:masterfrom Aug 16, 2022
Merged
DruidQuery: Return a copy from withScanSignatureIfNeeded, as promised.#12906gianm merged 1 commit intoapache:masterfrom
gianm merged 1 commit intoapache:masterfrom
Conversation
The method wasn't following its contract, leading to pollution of the overall planner context, when really we just want to create a new context for a specific query.
abhishekagarwal87
approved these changes
Aug 16, 2022
FrankChen021
approved these changes
Aug 16, 2022
gianm
added a commit
to gianm/druid
that referenced
this pull request
Jul 7, 2023
Taking the work done in apache#12906 a little further: 1) Applying a similar optimization to WorkerHolder (HttpRemoteTaskRunner). The original patch only helped with the ZkWorker (RemoteTaskRunner). 2) Improve the ZkWorker version somewhat by avoiding multiple iterations through the task announcements map.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method wasn't following its contract, leading to pollution of the overall planner context, when really we just want to create a new context for a specific query.