Remove misleading logging on router for JDBC queries#12925
Merged
rohangarg merged 1 commit intoapache:masterfrom Aug 22, 2022
Merged
Remove misleading logging on router for JDBC queries#12925rohangarg merged 1 commit intoapache:masterfrom
rohangarg merged 1 commit intoapache:masterfrom
Conversation
abhishekagarwal87
approved these changes
Aug 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a cluster with non
allow-allauthentication configured, JDBC queries log the following misleading message :Can not find Authenticator with Name [allowAll]. It is misleading since we useallow-allauthentication for JDBC queries to bypass the authentication on router itself. JDBC queries are authenticated on broker.The log comes because having an
authenticatedByfield in the bypass auth result leads the query to a codepath where the authenticator object is tried to be fetched. But since we haven't configuredallow-allauth, the error log comes.This change removes the
authenticatedByfield inAuthenticationResultfor bypass requests to avoid the misleading logging.This PR has: