Skip to content

Remove misleading logging on router for JDBC queries#12925

Merged
rohangarg merged 1 commit intoapache:masterfrom
rohangarg:authentication_log
Aug 22, 2022
Merged

Remove misleading logging on router for JDBC queries#12925
rohangarg merged 1 commit intoapache:masterfrom
rohangarg:authentication_log

Conversation

@rohangarg
Copy link
Member

On a cluster with non allow-all authentication configured, JDBC queries log the following misleading message : Can not find Authenticator with Name [allowAll]. It is misleading since we use allow-all authentication for JDBC queries to bypass the authentication on router itself. JDBC queries are authenticated on broker.
The log comes because having an authenticatedBy field in the bypass auth result leads the query to a codepath where the authenticator object is tried to be fetched. But since we haven't configured allow-all auth, the error log comes.
This change removes the authenticatedBy field in AuthenticationResult for bypass requests to avoid the misleading logging.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@rohangarg rohangarg merged commit a879d91 into apache:master Aug 22, 2022
@abhishekagarwal87 abhishekagarwal87 added this to the 24.0.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants