Skip to content

Web console: fix pagination, add error delimiters#12969

Merged
fjy merged 2 commits intoapache:masterfrom
vogievetsky:fix_pagination
Aug 25, 2022
Merged

Web console: fix pagination, add error delimiters#12969
fjy merged 2 commits intoapache:masterfrom
vogievetsky:fix_pagination

Conversation

@vogievetsky
Copy link
Contributor

This PR fixes the pagination control count and adds delimiters (/) for the error display:

image

@fjy
Copy link
Contributor

fjy commented Aug 25, 2022

nit:
I would use newline for Failed task id, On host, Debug
and add another delimiter for the sub-items under debug (download, archive, etc)

@vogievetsky
Copy link
Contributor Author

Ok, I rejiggered it a bit:

image

There is only one item under Debug, it is "download query detail archive" which I just renamed to "get query detail archive" because it is shorter, also get is less likely to be read as a single item vs download. The query detail archive is a single file that contains all the important query and execution details that can be sent to someone for debugging.

@fjy fjy merged commit fd6cfcb into apache:master Aug 25, 2022
@vogievetsky vogievetsky deleted the fix_pagination branch August 25, 2022 15:27
vogievetsky added a commit that referenced this pull request Aug 25, 2022
* fix pagination, add error delimiters

* reword debug message
@abhishekagarwal87 abhishekagarwal87 added this to the 24.0.0 milestone Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants