Conversation
|
When do the cron tests run and how can we see the results? Is there a way to run them on-demand on release branches? (Running "extra bonus" tests on release candidates seems like the best use of them.) Please forgive me for these basic questions; I'm just not familiar with how the cron tests work. |
|
|
||
| - <<: *integration_tests | ||
| name: "(Compile=openjdk8, Run=openjdk11) other integration test" | ||
| jdk: openjdk8 |
There was a problem hiding this comment.
Is this correct? This entry and all the other modified ones seem to be for jdk8.
There was a problem hiding this comment.
yes. druid gets compiled and built with JDK 8 but then tests are run on JRE 11.
I forgive you :) I don't see a way to run them on-demand on release branches. We can however make a slight change in |
|
I could also set a condition such that cron jobs would always run on master and release branches but not on pull requests. |
Seems like running them automatically on release branches would be good; that way, it makes life easier for release managers. They would be able to backport things without waiting for CI to pass on each PR, since they could look at the release-branch results after backports are done. That also ensures we run the full test suite on every release. |
Is this something that would be done in |
|
Final note: please also update |
|
@gianm - I have made the changes you suggested. PTAL. |
| The only additions to the release branch after branching should be bug fixes, which should be back-ported from the master branch, via a second PR or a cherry-pick, not with a direct PR to the release branch. | ||
|
|
||
| Once all issues and PRs that are still tagged with the release milestone have been merged, closed, or removed from the milestone, the next step is to put together a release candidate. | ||
| Release manager must also ensure that CI is passing successfully on the release branch. Since CI on branch can contain additional tests such as ITs for different JVM flavours. (Note that CI is sometimes flaky for older branches). |
There was a problem hiding this comment.
Could you please include some instruction about how to ensure that CI passes successfully on the branch? Like, a link or a description of what to click where?
.travis.yml
Outdated
| # 3. cron | ||
| # | ||
| # The cron type only runs jobs that are marked with stage cron. | ||
| # The cron type only runs jobs that are marked with stage cron. The ron stage also runs alongside |
| if: type != cron | ||
| - name: cron | ||
| if: type = cron | ||
| if: type = cron OR (type != pull_request AND branch != master) |
There was a problem hiding this comment.
https://docs.travis-ci.com/user/conditions-v1 says the possible type are push, pull_request, api, cron. So these tests will now additionally run for nonmaster branches if the event type is push or api. I guess api is for manually-triggered tests on branches. What's push for?
There was a problem hiding this comment.
I am guessing but it must be triggered for any commit that is pushed to the branch. I could not explicit documentation but that definition seems most plausible.
There was a problem hiding this comment.
Ok, let's try this and see if it does what we want.
3 participants
This PR moves some of the ITs for JRE 11 runtime to the cron stage. The reason is simple - we have a lot of tests and our PR checks take too long to finish. This would improve the situation slightly. I have kept the following ITs around
This PR has: