escape smoosh file names, fix bug with empty json paths#13079
escape smoosh file names, fix bug with empty json paths#13079clintropolis wants to merge 1 commit intoapache:masterfrom
Conversation
| */ | ||
| public class SmooshedFileMapper implements Closeable | ||
| { | ||
| private static final String COMMA = "\u002c"; |
There was a problem hiding this comment.
is it used anywhere?
| '0' == fileName.charAt(i + 1) && | ||
| '0' == fileName.charAt(i + 2) && | ||
| '2' == fileName.charAt(i + 3) && | ||
| 'c' == fileName.charAt(i + 4) |
There was a problem hiding this comment.
what if we are are exceeding the string length here?
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request has been marked as stale due to 60 days of inactivity. |
|
This pull request/issue has been closed due to lack of activity. If you think that |
Description
This PR fixes some issues encountered with nested column objects with key names containing newlines or commas, which while valid JSON, are not cool with the way the
meta.smooshfile currently works.To remedy this, the smoosh file now escapes commas and newlines when writing the
meta.smooshfile, and unescapes them upon mapping.This PR also fixes an issue with the jsonpath and jq parsers when handling empty keys, which are also valid JSON property names. They were both a bit overly strict, and now should allow them if contained in syntax appropriate quotes.
This PR has: