Merged
Conversation
Contributor
Author
|
ugh, this should be stacked on #13086 |
d1819db to
2a037dc
Compare
...c/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalAggregatorFactory.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalSqlAggregator.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/apache/druid/compressedbigdecimal/CompressedBigDecimalAggregatorFactory.java
Show resolved
Hide resolved
bb3b903 to
adb8c74
Compare
This adds a sql function, "BIG_SUM", that uses CompressedBigDecimal to do a sum. Other misc changes: 1. handle NumberFormatExceptions when parsing a string (default to set to 0, configurable in agg factory to be strict and throw on error) 2. format pom file (whitespace) + add dependency 3. scaleUp -> scale and always require scale as a parameter
Contributor
|
I realized this one has no docs attached. Can you help describe what is now possible that weren't possible before with BIG_SUM so that we can include this in the release notes? cc' @317brian |
This was referenced Dec 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a sql function, "BIG_SUM", that uses CompressedBigDecimal to do a sum. Other misc changes:
to 0, configurable in agg factory to be strict and throw on error)
Key changed/added classes in this PR
CompressedBigDecimalSqlAggregator- sql function definitions and arg parsingThis PR has: