Skip to content

fix(sec): upgrade org.bouncycastle:bcprov-ext-jdk15on to 1.69#13235

Closed
zhoumengyks wants to merge 1 commit intoapache:masterfrom
zhoumengyks:oscs_fix_cd71slgau51q1alfu0vg
Closed

fix(sec): upgrade org.bouncycastle:bcprov-ext-jdk15on to 1.69#13235
zhoumengyks wants to merge 1 commit intoapache:masterfrom
zhoumengyks:oscs_fix_cd71slgau51q1alfu0vg

Conversation

@zhoumengyks
Copy link

What happened?

There are 1 security vulnerabilities found in org.bouncycastle:bcprov-ext-jdk15on 1.68

What did I do?

Upgrade org.bouncycastle:bcprov-ext-jdk15on from 1.68 to 1.69 for vulnerability fix

What did you expect to happen?

Ideally, no insecure libs should be used.

The specification of the pull request

PR Specification from OSCS

@FrankChen021
Copy link
Member

The version is not updated in the licenses.yaml file, I'm curious that why doesn't the license check report error? Is it because the scope of this dependency is declared as 'runtime'? Do you know that @xvrl

<groupId>org.bouncycastle</groupId>
<artifactId>bcprov-ext-jdk15on</artifactId>
<version>1.68</version>
<version>1.69</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are we only updating bcprov-ext-jdk15on and not bcprov-jdk15on ?
We should also move to 1.70 since that is out already

@xvrl
Copy link
Member

xvrl commented Oct 24, 2022

@FrankChen021 good question, we'd have to remove the runtime scope to see if that makes a difference. I also wonder if the fact that we still have 1.68 for bcprov-jdk15on somehow causes the license check to be confused?

@github-actions
Copy link

This pull request has been marked as stale due to 60 days of inactivity.
It will be closed in 4 weeks if no further activity occurs. If you think
that's incorrect or this pull request should instead be reviewed, please simply
write any comment. Even if closed, you can still revive the PR at any time or
discuss it on the dev@druid.apache.org list.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 11, 2024
@github-actions
Copy link

github-actions bot commented Feb 9, 2024

This pull request/issue has been closed due to lack of activity. If you think that
is incorrect, or the pull request requires review, you can revive the PR at any time.

@github-actions github-actions bot closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants