Skip to content

Comments

Version Bump CSS#13253

Closed
AshishKapoor wants to merge 0 commit intoapache:masterfrom
AshishKapoor:version-bump-css
Closed

Version Bump CSS#13253
AshishKapoor wants to merge 0 commit intoapache:masterfrom
AshishKapoor:version-bump-css

Conversation

@AshishKapoor
Copy link
Contributor

@AshishKapoor AshishKapoor commented Oct 22, 2022

Description

Updated following node modules

"node-sass": "^7.0.1",
"postcss": "^8.4.18",
"postcss-loader": "^7.0.1",
"postcss-preset-env": "^7.8.2",
"sass-loader": "^13.1.0"

This PR has version bump for the named node modules

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

@vogievetsky
Copy link
Contributor

you need to update package-lock.json also

@AshishKapoor
Copy link
Contributor Author

AshishKapoor commented Nov 1, 2022

you need to update package-lock.json also

Done, good catch! @vogievetsky

Note: The CSS node-sass module is a pain to work with. I advocate for maybe eliminating it since it is losing any maintenance coming forward. I am sure it will require us some major changes in the web-pack bundler. Looking forward to your advice.

@vogievetsky
Copy link
Contributor

I would love to get rid os node-sass! Could you please merge master

@AshishKapoor
Copy link
Contributor Author

I would love to get rid os node-sass! Could you please merge master

@vogievetsky done!

@AshishKapoor AshishKapoor deleted the version-bump-css branch December 3, 2022 04:10
@AshishKapoor AshishKapoor restored the version-bump-css branch December 3, 2022 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants