fix bug when FrontCodedIndexed has only the null value#13309
Merged
clintropolis merged 1 commit intoapache:masterfrom Nov 4, 2022
Merged
fix bug when FrontCodedIndexed has only the null value#13309clintropolis merged 1 commit intoapache:masterfrom
clintropolis merged 1 commit intoapache:masterfrom
Conversation
imply-cheddar
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug with
FrontCodedIndexedwhen containing only a single null value. Because the null value is not actually stored in the "value buckets", it can result in a null pointer exception inFrontCodedIndexedWriterwhen serializing the column, and a buffer underflow inFrontCodedIndexedwhen creating an iterator on aFrontCodedIndexedwith only a null value, since the values section is actually empty.I also added bounds checking to the
getmethod ofFrontCodedIndexedas a safety measure, which if everything is written correctly shouldn't be needed, but also doesn't seem to add much performance impact so it seems worth the sanity checks it provides in the eventThis PR has: