fix flaky RemoteTaskRunnerTest.testRunPendingTaskFailToAssignTask with ugly Thread.sleep#13344
Merged
abhishekagarwal87 merged 1 commit intoapache:masterfrom Nov 10, 2022
Conversation
…h ugly Thread.sleep
kfaraz
approved these changes
Nov 10, 2022
Contributor
kfaraz
left a comment
There was a problem hiding this comment.
Thanks for fixing this, @clintropolis ! This has been failing consistently on recent PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RemoteTaskRunnerTest.testRunPendingTaskFailToAssignTaskfails pretty consistently if run until failure in intelij. After adding this thread.sleep i let it run for over 2k iterations without failure.I hate it, but it seems to significantly reduce the flakiness (at least i saw no failures) and I wasn't able to determine a "good" fix in a short amount of time so lets do this for now.
The underlying issue appears to be a race condition with test zk server and worker startup, where if the timing is incorrect an
INITIALIZEDevent that happens after the first pending task is added, can result in the task runner callingrunPendingTask, before the test is able to callrunPendingTask, which makes the test assertions no longer true.In successful runs, the logs have a section like:
but in the failure, there is no exception: