Skip to content

Comments

Fix messageGap emission#13346

Merged
AmatyaAvadhanula merged 4 commits intoapache:masterfrom
AmatyaAvadhanula:feature-fixMessageGap
Nov 10, 2022
Merged

Fix messageGap emission#13346
AmatyaAvadhanula merged 4 commits intoapache:masterfrom
AmatyaAvadhanula:feature-fixMessageGap

Conversation

@AmatyaAvadhanula
Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula commented Nov 10, 2022

Do not emit messageGap after streaming tasks stop processing events.

Description

Modify the emission of metrics to stop emitting messageGap after a task has stopped processing events on its own or due to a stop request etc.


Key changed/added classes in this PR
  • SeekableStreamIndexTaskRunner
  • FireDepartmentMetrics

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

Copy link
Contributor

@kfaraz kfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix, @AmatyaAvadhanula !

@AmatyaAvadhanula AmatyaAvadhanula merged commit fb23e38 into apache:master Nov 10, 2022
@kfaraz kfaraz added this to the 25.0 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants