Skip to content

Web console: react to user cancelation immediately#13376

Merged
vogievetsky merged 1 commit into
apache:masterfrom
vogievetsky:query-view-fixes
Nov 18, 2022
Merged

Web console: react to user cancelation immediately#13376
vogievetsky merged 1 commit into
apache:masterfrom
vogievetsky:query-view-fixes

Conversation

@vogievetsky
Copy link
Copy Markdown
Contributor

This PR makes the following changes to the console:

  • The requests on native queries are now immediately canceled, this is helpful in case a user makes a very large request (without a limit) and needs to cancel the query.
  • The "Query history" dialog now avoids and does not show up for multi-stage queries because they already show up in the "Recent query tasks" panel and it is confusing that there are two somewhat-history-like places in the UI for multi-stage queries. Also multi-stage queries are sometimes huge and those overwhelm the localStorage.
  • Update DQT to fix a small bug.

Copy link
Copy Markdown

@pengz-imply pengz-imply left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍 Thanks!

@vogievetsky vogievetsky merged commit a3d45f6 into apache:master Nov 18, 2022
@vogievetsky vogievetsky deleted the query-view-fixes branch November 18, 2022 22:04
@kfaraz kfaraz added this to the 25.0 milestone Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants