add missing vector object selector for multi-value string columns, refactor some stuff#13379
Merged
clintropolis merged 4 commits intoNov 18, 2022
Conversation
imply-cheddar
approved these changes
Nov 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing
VectorObjectSelectorfor multi-valueSTRINGtyped columns. Several complex aggregators useVectorObjectSelectorwhen they don't care for dealing with or can't do anything useful with dictionary lookup stuff directly, so this fills in the missing selector implementation to ensure if it is called that it doesn't explode.While I was here, this selector creating code is heavily copied between
StringDictionaryEncodedColumn,StringFrontCodedDictionaryEncodedColumn, and evenNestedFieldLiteralDictionaryEncodedColumn, so I have refactored the base machinery into abstract types and then each column implementation can bring its own dictionary to fill out how to do lookup, which was the primary difference between them.This PR has: