MSQ: Launch initial tasks faster.#13393
Merged
kfaraz merged 2 commits intoapache:masterfrom Nov 21, 2022
Merged
Conversation
Notify the mainLoop thread to skip a sleep when the desired task count changes.
gianm
added
the
Area - MSQ
cryptoe
reviewed
Nov 21, 2022
| // wait on taskIds so we can wake up early if needed. | ||
| synchronized (taskIds) { | ||
| taskIds.wait(sleepMillis); | ||
| if (acknowledgedDesiredTaskCount == desiredTaskCount) { |
Contributor
There was a problem hiding this comment.
Nit: Can we add a note here. Something like :
As desiredTaskCount can change in launchTasksIfNeeded which can be called externally from any thread, we need to way to wake up the main loop in case desiredTaskCount is changed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notify the mainLoop thread to skip a sleep when the desired task count changes.