Skip to content

Fix an issue with WorkerSketchFetcher not terminating on shutdown#13459

Merged
cryptoe merged 2 commits intoapache:masterfrom
adarshsanjeev:sketch-fetcher-threadpool-fix
Nov 30, 2022
Merged

Fix an issue with WorkerSketchFetcher not terminating on shutdown#13459
cryptoe merged 2 commits intoapache:masterfrom
adarshsanjeev:sketch-fetcher-threadpool-fix

Conversation

@adarshsanjeev
Copy link
Contributor

@adarshsanjeev adarshsanjeev commented Nov 30, 2022

Fixes an issue with WorkerSketchFetcher not terminating on shutdown due to relying on a fixed non daemon threadpool. Will also create a separate PR to add the same to the forbidden API list after resolving its usage in a lot of tests.

This PR has:

  • been self-reviewed.
  • added documentation for new or modified features or behaviors.
  • a release note entry in the PR description.
  • added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
  • added or updated version, license, or notice information in licenses.yaml
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added unit tests or modified existing tests to cover new code paths, ensuring the threshold for code coverage is met.
  • added integration tests.
  • been tested in a test Druid cluster.

cryptoe
cryptoe approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@cryptoe cryptoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@abhishekagarwal87 abhishekagarwal87 added this to the 25.0 milestone Nov 30, 2022
@kfaraz kfaraz added Bug Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Nov 30, 2022
@cryptoe cryptoe merged commit af164cb into apache:master Nov 30, 2022
@cryptoe
Copy link
Contributor

cryptoe commented Nov 30, 2022

Thanks for the fix @adarshsanjeev

adarshsanjeev added a commit to adarshsanjeev/druid that referenced this pull request Nov 30, 2022
@adarshsanjeev
Fix an issue with WorkerSketchFetcher not terminating on shutdown (ap…
caa7891 
…ache#13459)

* Fix an issue with WorkerSketchFetcher not terminating on shutdown

* Change threadpool name
@adarshsanjeev adarshsanjeev mentioned this pull request Nov 30, 2022
Merged
10 tasks
cryptoe pushed a commit that referenced this pull request Dec 1, 2022
@adarshsanjeev
Fix an issue with WorkerSketchFetcher not terminating on shutdown (#1…
ff3c83f 
…3459) (#13464)

* Fix an issue with WorkerSketchFetcher not terminating on shutdown

* Change threadpool name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gianm gianm gianm approved these changes

@cryptoe cryptoe cryptoe approved these changes

Assignees

No one assigned

Labels

Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Bug

Projects

None yet

Milestone

25.0

Development

Successfully merging this pull request may close these issues.

5 participants

@adarshsanjeev @cryptoe @gianm @abhishekagarwal87 @kfaraz