docs: notebook only for SQL tutorial#13465
Merged
techdocsmith merged 12 commits intoapache:masterfrom Feb 9, 2023
Merged
Conversation
317brian
requested changes
Dec 7, 2022
Contributor
317brian
left a comment
317brian
left a comment
There was a problem hiding this comment.
Some minor comments. Based on feedback on my notebook from Charles, you'll need to update your print statements with some formatting and adding context. See 5594ec6 (#13345) for an example
317brian
approved these changes
Dec 15, 2022
Contributor
317brian
left a comment
317brian
left a comment
There was a problem hiding this comment.
Great job! I learned a lot doing this tutorial
ektravel
commented
Dec 16, 2022
techdocsmith
requested changes
Jan 4, 2023
Contributor
techdocsmith
left a comment
techdocsmith
left a comment
There was a problem hiding this comment.
@ektravel , this is a great introduction to Druid SQL. I've provided some feedback, but this is almost there.
techdocsmith
reviewed
Jan 4, 2023
…l/druid into add-sql-tutorial-nb-only
techdocsmith
requested changes
Feb 2, 2023
Contributor
techdocsmith
left a comment
techdocsmith
left a comment
There was a problem hiding this comment.
@ektravel , I continue to be impressed by this tutorial. Great job. I've requested a few further refinements, but this is such a helpful topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
Adds the Jupyter notebook file sql-tutorial.ipynb
This PR has: