New IT Framework - InputSource and InputFormat Tests

[abhagraw]

Migrating InputSource and InputFormat Tests to the new IT framework.

The following tests are being migrated to the new framework -

ITHttpInputSourceTest.java
ITLocalInputSourceAllInputFormatTest.java
ITSqlInputSourceTest.java

[cryptoe]

Minor comments. WIll merge after CICD

[cryptoe]

Why is this indexer-specific test? Should this package be something else like inputsource

[paul-rogers]

This is an existing package. I believe "indexer" is the name of the service that does ingestion, not just the name of a process that manages tasks.

[abhagraw]

Was following the existing structure. We can create a new package if required.

[cryptoe]

Ahh maybe we can change it in another PR .

[cryptoe]

@abhagraw Also please mention the exact tests which are being migrated as part of the PR description for the trail.

[paul-rogers]

Looks good. Thanks for doing the conversion. For this one, it appears we were able to reuse the code pretty much as-is. That is a good outcome: it allows tests to be converted rapidly.

I wonder, as we convert, should we remove the old tests? Or, at least leave a comment indicating that they have been converted? Doing so will make it easier to track the conversions as we move beyond having just a handful.

Other than the formatting issue pointed out below, LGTM.

[paul-rogers]

This is an existing package. I believe "indexer" is the name of the service that does ingestion, not just the name of a process that manages tasks.

[abhagraw]

Looks good. Thanks for doing the conversion. For this one, it appears we were able to reuse the code pretty much as-is. That is a good outcome: it allows tests to be converted rapidly.

I wonder, as we convert, should we remove the old tests? Or, at least leave a comment indicating that they have been converted? Doing so will make it easier to track the conversions as we move beyond having just a handful.

Other than the formatting issue pointed out below, LGTM.

@paul-rogers Currently we only run tests on jvm 8 using the new framework. We need to add support for running on jvm 11 to remove the old framework tests completely.

[cryptoe]

Thanks, @abhagraw for migrating these tests!!