Skip to content

Comments

Remove unnecessary python topic. Style changes to quickstart.#13647

Merged
vtlim merged 9 commits intoapache:masterfrom
techdocsmith:clean-quickstart
Apr 7, 2023
Merged

Remove unnecessary python topic. Style changes to quickstart.#13647
vtlim merged 9 commits intoapache:masterfrom
techdocsmith:clean-quickstart

Conversation

@techdocsmith
Copy link
Contributor

This PR has:

  • been self-reviewed.

Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worthwhile improvements! Suggested a few changes.

techdocsmith and others added 2 commits January 25, 2023 12:27
Prerequisites
Co-authored-by: Victoria Lim <vtlim@users.noreply.github.com>

In addition, Druid includes several [bundled non-automatic profiles](../operations/single-server.md) for a range of machine sizes. These range from nano (1 CPU, 4GiB RAM) to x-large (64 CPU, 512GiB RAM).
We won't use those here, but for more information, see [Single server deployment](../operations/single-server.md). For additional information on deploying Druid services across clustered machines, see [Clustered deployment](./cluster.md).
In addition, Druid includes several [bundled static profiles](../operations/single-server.md) for a range of machine sizes. These range from nano (1 CPU, 4 GiB RAM) to x-large (64 CPU, 512 GiB RAM).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps add, "Many people use the micro-quickstart profile when learning Druid." That way, folks won't have to guess which one to pick to get started.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to pick one. /bin/start-druid should theoretically work without having to specify.

> Druid relies on the environment variables `JAVA_HOME` or `DRUID_JAVA_HOME` to find Java on the machine. You can set
`DRUID_JAVA_HOME` if there is more than one instance of Java. To verify Java requirements for your environment, run the
`bin/verify-java` script.
You must set either the `JAVA_HOME` or `DRUID_JAVA_HOME` environment variable for Druid to find Java on the machine. If there is more than one version of Java installed, set
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this true? I suspect we can also infer the location from the java command. For example, on my machine, I have neither of the above env vars set, but java is on the path.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion:

Java must be available. Either it is on your path, or set one of the JAVA_HOME or DRUID_JAVA_HOME environment variables.


All persistent state, such as the cluster metadata store and segments for the services, are kept in the `var` directory under
the Druid root directory, apache-druid-{{DRUIDVERSION}}. Each service writes to a log file under `var/sv`.
It may use up to 80% of the total available system memory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It -> "Druid"

To explicitly set the total memory available to Druid, pass a value for the memory parameter. For example, `./bin/start-druid -m 16g`.

Druid stores all persistent state data, such as the cluster metadata store and data segments, in `apache-druid-{{DRUIDVERSION}}/var`.
Each service writes to a log file under `var/sv`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did we change that again? In my latest build, logs go to $DRUID_HOME/log.

(See how smooth it is to use $DRUID_HOME instead of apache-druid-{{DRUIDVERSION}}?

Also, note that here we are prefixing var with apache-druid-{{DRUIDVERSION}}, where as above we just referenced bin without a prefix.

## Open the web console

After the Druid services finish startup, open the [web console](../operations/web-console.md) at [http://localhost:8888](http://localhost:8888).
After the Druid services launch, open the [web console](../operations/web-console.md) at [http://localhost:8888](http://localhost:8888).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, it takes some time for the services to become ready after they "launch." Maybe:

After starting the Druid services, open ...

Change instances of 16 GiB to 6 GiB
Copy link
Member

@vtlim vtlim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@paul-rogers paul-rogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we can fix the Java wording, the rest looks good to go.

Note on the Python 2 thing: as we add notebooks, we'll depend on Python 3. It will be fiddly to say that Druid can run with Python 2, but the notebooks need Python 3. Maybe we can say:

Python 2 or Python 3 (preferred)

@vtlim vtlim merged commit 166cb62 into apache:master Apr 7, 2023
@clintropolis clintropolis added this to the 26.0 milestone Apr 10, 2023
@techdocsmith techdocsmith deleted the clean-quickstart branch April 26, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants